Only consider personal details with logins set in `OptionsListUtils.getOptions` #21159

jasperhuangg · 2023-06-20T20:53:26Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/293465
$ #21040
$ https://github.com/Expensify/Expensify/issues/293416

Tests

Group DMs

Click FAB > New group
Select any random email and concierge as members
Click "Create Group"
Verify the group is created successfully
Check the personalDetailsList in Onyx and ensure personal detail objects without logins aren't displayed in the options list.

Tasks

Click FAB > Assign Task
Fill in the title/description. Click "Next"
Click "Assignee". Check the personalDetailsList in Onyx and ensure personal detail objects without logins aren't displayed in the options list.
Select any assignee.
Click "Confirm task"
Verify that the task is created successfully, and displays the assignee correctly.
Click on the assignee in the task. Check the personalDetailsList in Onyx and ensure personal detail objects without logins aren't displayed in the options list.
Select another assignee. Verify that the assignee for the task is updated successfully.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

aldo-expensify · 2023-06-20T22:05:43Z

src/libs/OptionsListUtils.js

+    // We're only picking personal details that have logins set
+    // This is a temporary fix for all the logic that's been breaking because of the new privacy changes
+    // See https://github.com/Expensify/Expensify/issues/293465 for more context
+    // eslint-disable-next-line no-param-reassign
+    personalDetails = _.pick(personalDetails, (detail) => Boolean(detail.login));


What are the effects of excluding personal details from this object? They don't appear in the option list?

Do you know where this was causing problems down the line? I imagine we where trying to use personalDetails.login which was missing, but in other fixes we have been adding personalDetails.login || personalDetails.displayName... just wondering why that approach was not good here.

Because Tasks takes the login from the option and does a lot more stuff with it, so we can't just do that

Also, it's not guaranteed that personalDetails.displayName is equal to their login. If they have a display name set already then it won't be equal. That only applies to new users that haven't set their personal details yet.

I assume that we actually needed the login (emails) for the flows that broke downstream, so using the displayName might not be enough

That only applies to new users

Then it can be that the personalDetails.login is missing for users that are not new? I mean, can it happen that personalDetails.login is missing and personalDetails.displayName is missing?

In the cases I have seen so far, when the login is missing, the displayName is the email address.

In the cases I have seen so far, when the login is missing, the displayName is the email address.

Is this still true if the user sets their display name?

that's definitely possible - maybe you can check with Puneet's updated query here? https://github.com/Expensify/Auth/pull/8153

ok, this Auth fix works for 1:1 DM's

It's intended to also work for group DMs

Now to the last part of the issue, where if I have DM some random new users and send some messages. The chat appears in LHN. Again, when I go to chat switcher and type full email, and click on option, it creates a new report with same user

I reported here, in case it is already known

melvin-bot · 2023-06-20T22:13:57Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg · 2023-06-20T22:16:19Z

Unassigning C+ for urgency as this is a fire

luacmartins · 2023-06-20T22:47:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

github-actions · 2023-06-20T22:50:38Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

…WithoutLogins Only consider personal details with logins set in `OptionsListUtils.getOptions` (cherry picked from commit b7069ec)

…-21159 🍒 Cherry pick PR #21159 to staging 🍒

OSBotify · 2023-06-21T01:47:56Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-21T02:16:37Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T22:17:31Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-26T20:48:08Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-08-07T22:41:41Z

src/libs/OptionsListUtils.js

+    // We're only picking personal details that have logins set
+    // This is a temporary fix for all the logic that's been breaking because of the new privacy changes
+    // See https://github.com/Expensify/Expensify/issues/293465 for more context
+    // eslint-disable-next-line no-param-reassign


Is there any follow up issues to address the temp fix?

Yep, we just recently merged the PR that handles when you try to chat with someone whose login you don't have in Onyx, so we should be able to undo this now. I'll create an issue for a contributor to do it.

Or maybe actually I can just revert this.

rushatgabhane · 2023-09-05T18:14:33Z

src/libs/OptionsListUtils.js

+    // This is a temporary fix for all the logic that's been breaking because of the new privacy changes
+    // See https://github.com/Expensify/Expensify/issues/293465 for more context
+    // eslint-disable-next-line no-param-reassign
+    personalDetails = _.pick(personalDetails, (detail) => Boolean(detail.login));


Hi, we should have placed this code just before creating an option

It would have prevented bug - Tooltip content only have comma in content when hovering group chat with non-register users

More details - #22593 (comment)

only consider personal details with logins set

9af9c96

jasperhuangg self-assigned this Jun 20, 2023

jasperhuangg added 3 commits June 20, 2023 13:54

style

6d3cea1

remove unused

fc0916a

add issue link

1fcc839

jasperhuangg mentioned this pull request Jun 20, 2023

[HOLD for payment 2023-06-29] Web - Group chat - "Invalid email" error message appears when creating a group DM with Concierge #21040

Closed

6 tasks

aldo-expensify reviewed Jun 20, 2023

View reviewed changes

jasperhuangg marked this pull request as ready for review June 20, 2023 22:13

jasperhuangg requested a review from a team as a code owner June 20, 2023 22:13

melvin-bot bot requested review from s77rt and removed request for a team June 20, 2023 22:13

jasperhuangg removed the request for review from s77rt June 20, 2023 22:16

luacmartins added the CP Staging label Jun 20, 2023

luacmartins previously approved these changes Jun 20, 2023

View reviewed changes

fix error with description being unset

116abf5

jasperhuangg dismissed luacmartins’s stale review via 116abf5 June 20, 2023 23:02

puneetlath approved these changes Jun 21, 2023

View reviewed changes

luacmartins approved these changes Jun 21, 2023

View reviewed changes

luacmartins merged commit b7069ec into main Jun 21, 2023

luacmartins deleted the jasper-filterPersonalDetailsWithoutLogins branch June 21, 2023 01:04

OSBotify pushed a commit that referenced this pull request Jun 21, 2023

Merge pull request #21159 from Expensify/jasper-filterPersonalDetails…

1070721

…WithoutLogins Only consider personal details with logins set in `OptionsListUtils.getOptions` (cherry picked from commit b7069ec)

OSBotify mentioned this pull request Jun 21, 2023

🍒 Cherry pick PR #21159 to staging 🍒 #21167

Merged

OSBotify added a commit that referenced this pull request Jun 21, 2023

Merge pull request #21167 from Expensify/OSBotify-cherry-pick-staging…

ef68efa

…-21159 🍒 Cherry pick PR #21159 to staging 🍒

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

situchan mentioned this pull request Jun 22, 2023

FAB - Missing conversations in recent list #21283

Closed

6 tasks

OSBotify mentioned this pull request Jun 24, 2023

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed

45 tasks

MonilBhavsar mentioned this pull request Jun 29, 2023

[WIP] Filter search options by accountID #20933

Closed

57 tasks

dukenv0307 mentioned this pull request Jun 30, 2023

[$1000] Web - "Hmm... it's not here" page is displayed when creating task #21896

Closed

6 tasks

marcaaron reviewed Aug 7, 2023

View reviewed changes

rushatgabhane reviewed Sep 5, 2023

View reviewed changes

rushatgabhane mentioned this pull request Sep 5, 2023

[HOLD for payment 2023-09-06] [$1000] Tooltip content only have comma in content when hovering group chat with non-register users #22593

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only consider personal details with logins set in `OptionsListUtils.getOptions` #21159

Only consider personal details with logins set in `OptionsListUtils.getOptions` #21159

jasperhuangg commented Jun 20, 2023 •

edited

Loading

aldo-expensify Jun 20, 2023

jasperhuangg Jun 20, 2023 •

edited

Loading

luacmartins Jun 20, 2023

aldo-expensify Jun 20, 2023 •

edited

Loading

luacmartins Jun 20, 2023

Beamanator Jun 21, 2023

MonilBhavsar Jun 21, 2023

Beamanator Jun 21, 2023

MonilBhavsar Jun 21, 2023

MonilBhavsar Jun 21, 2023

melvin-bot bot commented Jun 20, 2023

jasperhuangg commented Jun 20, 2023

luacmartins commented Jun 20, 2023 •

edited

Loading

github-actions bot commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

marcaaron Aug 7, 2023

puneetlath Aug 31, 2023

puneetlath Aug 31, 2023

rushatgabhane Sep 5, 2023

Only consider personal details with logins set in OptionsListUtils.getOptions #21159

Only consider personal details with logins set in OptionsListUtils.getOptions #21159

Conversation

jasperhuangg commented Jun 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Group DMs

Tasks

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

jasperhuangg Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldo-expensify Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 20, 2023

jasperhuangg commented Jun 20, 2023

luacmartins commented Jun 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Only consider personal details with logins set in `OptionsListUtils.getOptions` #21159

Only consider personal details with logins set in `OptionsListUtils.getOptions` #21159

jasperhuangg commented Jun 20, 2023 •

edited

Loading

jasperhuangg Jun 20, 2023 •

edited

Loading

aldo-expensify Jun 20, 2023 •

edited

Loading

luacmartins commented Jun 20, 2023 •

edited

Loading